refactor: use bind-decorator to bind methods to this #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
bind-this-decorator
branch
2 times, most recently
from
cbacd7d to
1f8796b
Compare
miniak
force-pushed
the
bind-this-decorator
branch
from
1f8796b to
f5678a2
Compare
akgupta0777
reviewed
May 24, 2022
| @@ -43,6 +43,7 @@ | |||
| "@octokit/rest": "^16.43.1", | |||
| "@sentry/electron": "^2.5.3", | |||
| "@types/getos": "^3.0.1", | |||
| "bind-decorator": "^1.0.11", | |||
There was a problem hiding this comment.
Instead of adding a new dependency can you make a custom Autobind decorator. Learn about them here
|
I think the MobX upgrade clears the path for us to migrate off of class components altogether moving forward as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1027