Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriorityQueue for dead Connection can have the same timestamp #936

Closed
paulefoe opened this issue Apr 26, 2019 · 1 comment · Fixed by #938
Closed

PriorityQueue for dead Connection can have the same timestamp #936

paulefoe opened this issue Apr 26, 2019 · 1 comment · Fixed by #938

Comments

@paulefoe
Copy link
Contributor

I recently started investigating this issue in aioelasticsearch:
aio-libs/aioelasticsearch#100

And it turns out that potentially if few of the connections getting killed at the same time it could raise an error because PriorityQueue tries to compare two instances of Connection.
In my opinion, two instances of Connection should be considered equal and PriorityQueue then can easily handle such a situation.

I'd gladly provide a PR for that feature if you're okay with this.

Here's what I did in case of aioelasticsearch:
aio-libs/aioelasticsearch#164

@fxdgear
Copy link
Contributor

fxdgear commented Apr 26, 2019

@Svalee I'd love a patch. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants