Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check of addresses on connection creation #88

Open
maxekman opened this issue Feb 22, 2022 · 3 comments
Open

Add check of addresses on connection creation #88

maxekman opened this issue Feb 22, 2022 · 3 comments

Comments

@maxekman
Copy link
Member

maxekman commented Feb 22, 2022

We stumbled upon an issue where the address for the transmitter was nil, which was unfortunately only detected at runtime (which in the case of the RD service meant that it was not detected on the HIL).

I suggest a "dummy" transmit or other check of the address on connection creation: https://github.com/einride/lcm-go/blob/master/transmitter.go#L75

The reason for the error and the fix, for reference: https://github.com/einride/rd/pull/264

@maxekman
Copy link
Member Author

@Edholm Any thoughts on this?

@maxekman maxekman changed the title Add dummy transmit on connection creation Add check of addresses on connection creation Feb 22, 2022
@Edholm
Copy link
Member

Edholm commented Feb 22, 2022

Hm yeah why not? Isn't the config required? Or why was it allowed to be missing? 🤔

@maxekman
Copy link
Member Author

maxekman commented Feb 22, 2022

It was of type net.UDPAddr which can't be parsed by envconfig. netaddr.IPPort should be used instead, with a .UDPAddr() call to convert it where used. Very sneaky bug to find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants