Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm dist: absolute path will break website served from subfolder #255

Open
noraj opened this issue Jul 26, 2019 · 0 comments
Open

npm dist: absolute path will break website served from subfolder #255

noraj opened this issue Jul 26, 2019 · 0 comments

Comments

@noraj
Copy link
Contributor

noraj commented Jul 26, 2019

In the npm package if I do npm i docute there is a dist folder whic contains:

  • docute.js
  • docute.css
  • index.html

The link href is /docute.css and the script src is /docute.js. But adding a front / will break the app if it is served from a subfolder, eg. https://example.org/site/index.html because https://example.org/docute.js won't exist, it will be https://example.org/site/docute.js.

So I suggest to just put src="docute.js" and same for the css.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noraj