-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get into upstream QtCreator #3
Comments
Sure, the main functionality, reading editorconfig files and applying them to files, is ready. I think the best solution for spreading qtcreator plugins is to provide them upstream. Maybe, despite of having some additional plans for it, I shall do it now. |
Are there any updates regarding this? The bug on QtCreator seems to have no activity... |
@hgraeber I see the hold up for that bug is due to the 3rd party libraries of editorconfig-core-c and pcre. Recently I started implementing the editorconfig core in pure Qt5 (for my own purposes) that does not rely on any outside libraries. I plan on releasing this "soon" if/when I get some free time to test it some more. I'm assuming this would be of interest to you? |
@dail8859 My own implementation based on Qt5 is nearly ready and I will publish it here as part of the editorconfig project, too. Nevertheless thanks for your offer.If your code is accessible for me, I will have a look. Maybe we can join forces. |
@hgraeber Good to hear. After trying to run my version against the |
Any updates on this? Also Qt Creator 4.7.0 has received no build so far. Am I missing something? |
Upstream doesn't like additional dependencies like editorconfig-core-c and pcre. It already has pcre2. I will make a build for qt-creator soon. |
Why not |
pcre2 is not my choice, but used indirectly via editorconfig-core-c. When editorconfig-qtcreator will go upstream, I aim to replace editorconfig-core-c with a more Qt-ish core and use QRegularExpression (Which uses a copy of pcre2 internally) instead. std::regex is tabou, because Qt and QtCreator shall work with older C++ compilers and runtime libraries, too. |
hello, is there any news about this? |
I want to switch to editorconfig-core-qt, which is not ready yet. This one uses Qt functionality for regex and maybe be more acceptable for inclusion in qtcreator. |
Editorconfig-qtcretor is on the way to become part of qtcreator. It will use editorconfig-core-c and possibly editorconfig-core-qt later. |
This is good news! Let me know if you need any help regarding to editorconfig-core-c. |
In #1 (comment) it was mentioned:
This plugin seems to work, and it would resolve QTCREATORBUG-14013, I guess.
So, any plans for including the plugin into the QtCreator upstream distribution?
The text was updated successfully, but these errors were encountered: