You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This checks instanceof Selenium2Driver and fires $driver->start() then does a resize. However, not all drivers that support screenshots are Selenium2Driver (eg DMore/chrome-mink-driver's ChromeDriver.
So ChromeDriver retains resized dimensions between runs (until Chrome exits), while Selenium is consistent. That's not a problem for me - but to implement initial size from behat.yml config in that function for drivers other than Selenium2, we'd need to have that function accommodate those other drivers too.
The text was updated successfully, but these errors were encountered:
xurizaemon
changed the title
Initial screensize inconsistency in non-Selenium drivers
Make initialisation consistent for Selenium and non-Selenium drivers
Jul 5, 2021
We should not only add a better check, but also have multiple different drivers setup in CI to make sure that this extension works with all of them correctly.
Looking at #30 today I noticed an inconsistency in behaviour (I think).
https://github.com/integratedexperts/behat-screenshot/blob/master/src/IntegratedExperts/BehatScreenshotExtension/Context/ScreenshotContext.php#L73-L92
This checks
instanceof Selenium2Driver
and fires $driver->start() then does a resize. However, not all drivers that support screenshots are Selenium2Driver (eg DMore/chrome-mink-driver's ChromeDriver.So ChromeDriver retains resized dimensions between runs (until Chrome exits), while Selenium is consistent. That's not a problem for me - but to implement initial size from behat.yml config in that function for drivers other than Selenium2, we'd need to have that function accommodate those other drivers too.
The text was updated successfully, but these errors were encountered: