Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GTF_DEBUG_NODE_MORPHED. #6218

Closed
pgavlin opened this issue Jun 27, 2016 · 1 comment · Fixed by #110787
Closed

Remove GTF_DEBUG_NODE_MORPHED. #6218

pgavlin opened this issue Jun 27, 2016 · 1 comment · Fixed by #110787
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@pgavlin
Copy link
Contributor

pgavlin commented Jun 27, 2016

This debug-only GenTree flag is of questionable utility. See dotnet/coreclr#6002 for more discussion.

category:correctness
theme:ir
skill-level:intermediate
cost:small

@pgavlin pgavlin self-assigned this Jun 27, 2016
@briansull briansull changed the title Remove GTF_DEBUG_MORPHED. Remove GTF_DEBUG_NODE_MORPHED. Jun 27, 2016
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@AndyAyersMS
Copy link
Member

Seems like the main concern is not that we over morph but that we miss out on morphing something entirely. But I suppose in those cases where morphing actually does something required lack of morphing should become evident.

@BruceForstall BruceForstall removed the JitUntriaged CLR JIT issues needing additional triage label Jan 24, 2023
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Dec 17, 2024
Allow remorphing. Require that all nodes be morphed. Ensure that no node
is morphed more than a handful of times.

Fixes dotnet#6218, dotnet#56962, dotnet#107542
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants