Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All kinds of strange things when batch size is not equal to max_batch_size #10

Open
dfdx opened this issue Sep 15, 2024 · 0 comments
Open

Comments

@dfdx
Copy link
Owner

dfdx commented Sep 15, 2024

JAX is quite strict about buffer sizes, and so it's generally expected that a user applies models with batch size equal to ModelArgs.max_batch_size. Yet, we neither forbid different batch sizes, nor handle it properly. In some cases, different batch size leads to matrix size issues, in other cases the returned array has incorrect size, etc.

We need to either validate input tensors, or handle cases of batch size < max_batch_size properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant