Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(fs): do not write files in source tree during test #5358

Open
kt3k opened this issue Jul 9, 2024 · 2 comments · May be fixed by #6236
Open

test(fs): do not write files in source tree during test #5358

kt3k opened this issue Jul 9, 2024 · 2 comments · May be fixed by #6236
Labels
good first issue Good for newcomers

Comments

@kt3k
Copy link
Member

kt3k commented Jul 9, 2024

std/fs test cases directly write files in source tree during test. This makes debugging of test cases difficult when they failed in the middle. These test cases should use temp directory instead.
@kt3k kt3k added the good first issue Good for newcomers label Nov 13, 2024
@jbronder
Copy link

I'd be interested in working through these. I looked over some of the test files and it looks like copy_test.ts and exists_test.ts do incorporate making temp directories. I imagine similar approaches for the other applicable _test.ts files.

@kt3k
Copy link
Member Author

kt3k commented Nov 28, 2024

Thanks!

I looked over some of the test files and it looks like copy_test.ts and exists_test.ts do incorporate making temp directories. I imagine similar approaches for the other applicable _test.ts files.

Yes, that's correct

jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): move tests write to temp dirs (denoland#5358)
ece18d8
jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): ensureDir test write to temp dir (denoland#5358)
7042b20
jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): ensureFile test write to tmp dir (denoland#5358)
17df37c
jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): ensureLink test write to tmp dir (denoland#5358)
efd3567
jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): ensureSymlink tests write to temp dir (denoland#5358)
d6c34d7
jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): walk tests write to temp dirs (denoland#5358)
4186412
jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): child process scripts empty contents from tmp dirs (denolan…
413da75 
…d#5358)
jbronder added a commit to jbronder/deno_std that referenced this issue Dec 4, 2024
@jbronder
test(fs): emptyDir tests write to tmp dirs (denoland#5358)
063a9f0
@jbronder jbronder linked a pull request Dec 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(fs): do not write files in source tree during test (#5358) jbronder/deno_std
2 participants
@kt3k @jbronder