Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define messaging protocol to send delta updates to client #67

Closed
Tracked by #50
mofojed opened this issue Sep 21, 2023 · 1 comment · Fixed by #129
Closed
Tracked by #50

Define messaging protocol to send delta updates to client #67

mofojed opened this issue Sep 21, 2023 · 1 comment · Fixed by #129
Assignees
@mofojed
Labels
deephaven.ui

Comments

@mofojed
Copy link
Member

mofojed commented Sep 21, 2023 •
edited
Loading

  • Don't resend exported objects or callables if they haven't been modified
@mofojed mofojed mentioned this issue Sep 21, 2023
Open
89 tasks
@mofojed mofojed mentioned this issue Dec 8, 2023
Merged
@mofojed mofojed self-assigned this Dec 8, 2023
@mofojed
Copy link
Member Author

mofojed commented Dec 12, 2023

Document updates will be #123

mofojed added a commit that referenced this issue Dec 13, 2023
@mofojed
feat(ui): Only send new exported objects (#129)
be85375 
- Instead of resending the full list of exported objects each time, just
send the newly exported objects
- Increment the ID for each new object that is created
- Keep a weak reference to old objects so they are released when no
longer referenced
- Objects remain the same between renders 
- Tested using the steps in #128 
- Fixes #128, fixes #67
- Needs deephaven/deephaven-core#4909 to handle
fetching objects multiple times if necessary

BREAKING CHANGE: JSON protocol now keeps the IDs of objects and
callables stable between re-renders, and only exports new objects with
each documentUpdated event. The client must track the old objects
independently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
deephaven.ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui): Only send new exported objects mofojed/deephaven-plugins
1 participant
@mofojed