Replies: 1 comment
-
All new tests related to snapshot improvements are added in dbt-core repository. Shouldn't they be added to dbt-adapters repository instead? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Overview
This discussion is for communicating to adapter maintainers the scope of work needed to make use of the changes in dbt-core 1.9.0. If you have questions and concerns, please ask them here for posterity.
If there's something missing, please comment below!
Release timeline
The below table gives the milestones between up to and including the final release.
Prior maintainer upgrade guides
Example Diffs
TL;DR
There should be no breaking changes -- we hope and believe that things should work by bumping package and dependency versions -- please let us know if otherwise! We recommend adding tests where possible / appropriate and updating implementations within your adapter as needed to pass those tests -- see below for details.
Microbatch incremental strategy
See here for a detailed maintainer guide that is specific to microbatches: dbt-labs/dbt-adapters#371
Tests
dbt.tests.adapter.incremental.test_incremental_microbatch.BaseMicrobatch
Examples how to implement
valid_incremental_strategies
(first available in 1.3):valid_incremental_strategies
:Snapshot improvements
There are several improvements listed below that give users more control over their snapshots.
If you have any customizations for macros related to dbt snapshots, you will need to update them so they are compatible with the following features.
Additional context is also available in the epic.
Snapshots: Enable setting a datetime value for
dbt_valid_to
for current records instead ofNULL
For adapters using the default snapshot macros without overrides, this feature will be automatically inherited due to the changes in dbt-adapters#321.
The documentation for this feature was added in docs.getdbt.com#6308.
Test examples
BaseSnapshotDbtValidToCurrent
Examples how to implement
Snapshots: Enable
hard_deletes
config to add a metadata column if a record has been deletedFor adapters using the default snapshot macros without overrides, this feature will be automatically inherited due to the changes in dbt-adapters#317.
The documentation for this feature was added in docs.getdbt.com#6558.
Tests
dbt.tests.adapter.simple_snapshot.new_record_mode
Snapshots: Allow customizing names of metadata fields
For adapters using the default snapshot macros without overrides, this feature will be automatically inherited due to the changes in dbt-adapters#290.
The documentation for this feature was added in docs.getdbt.com#6211.
Test examples
BaseSnapshotColumnNamesFromDbtProject
BaseSnapshotColumnNames
BaseSnapshotInvalidColumnNames
Examples how to implement
Snapshots: Enable
unique_key
as a listFor adapters using the default snapshot macros without overrides, this feature will be automatically inherited due to the changes in dbt-adapters#326.
The documentation for this feature was added in docs.getdbt.com#6438.
Test examples
BaseSnapshotMultiUniqueKey
Beta Was this translation helpful? Give feedback.
All reactions