allow users to set cache_directory via env-var, #1965 #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
woutervh
changed the title
davidhalter
reviewed
Oct 18, 2023
jedi/settings.py
Outdated
| The cache-directory can be explicitly set by an environment-variable | ||
| ``JEDI_CACHE_DIR``. | ||
|
|
||
| If this env-var is not set, then |
There was a problem hiding this comment.
Can you revert this sentence? I don't like the grammar.
|
Now it's not documented anymore. Sorry I don't have the patience for this. I initially rejected this, so I'm going to close. |
|
what does the word "revert" mean in your dictionary? |
|
Python applications and certainly libraries should never write anything to hardcoded unconfigurable directories. I don't understand your objection to such no brainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #1965