Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point field support #26

Open
qenops opened this issue May 6, 2022 · 2 comments
Open

Point field support #26

qenops opened this issue May 6, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@qenops
Copy link

qenops commented May 6, 2022

After exporting an e57 file from CloudCompare, I noticed some extra point fields that are not in the SUPPORTED_POINT_FIELDS dictionary. I don't know if CloudCompare is just writing non-standard field names, or if they were just missed in the dictionary. Is there an official list of point fields for the e57 format?

The field names that it creates are: "nor:normalX", "nor:normalY", and "nor:normalZ"

I've added the fields locally for now, but our tool chain pulls repos from pypi, so long term it would be much easier if they were included here. However, if they aren't standard fields then of course they shouldn't be.

@qenops
Copy link
Author

qenops commented May 13, 2022

Maybe the code could be modified to include some unknown point field names that default to double? IDK, just spit balling.

@Saiga1105
Copy link

Saiga1105 commented Jul 19, 2022

Dear David,
Can you update the SUPPORTED_POINT_FIELDS to be more flexible. that cloudcompare bug with the normals is kinda enoying. Thanks

for those that specifically need CC normals, just update the dictionary in your code by adding this line at the top of your code:
pye57.e57.SUPPORTED_POINT_FIELDS.update({'nor:normalX' : 'd','nor:normalY': 'd','nor:normalZ': 'd'})

@dancergraham dancergraham added enhancement New feature or request help wanted Extra attention is needed labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants