Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Refactor evaluation.PrintResults signature #438

Open
noaabarki opened this issue Feb 24, 2022 · 0 comments
Open

Refactor evaluation.PrintResults signature #438

noaabarki opened this issue Feb 24, 2022 · 0 comments
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task

Comments

@noaabarki
Copy link
Contributor

Describe the solution you'd like

Location: bl/evaluation/printer:

func PrintResults(results ResultType, invalidYamlFiles []*validation.InvalidYamlFile, invalidK8sFiles []*validation.InvalidK8sFile, 
									evaluationSummary printer.EvaluationSummary, 
									loginURL string, outputFormat string, 
									printer Printer, k8sVersion string, policyName string) error {....}

In this function, we have nine arguments in total, and apparently they don’t have a logical order. We could try make sense of this arguments, but we can only guess by just looking at the argument. Following clean code conventions we want to group this arguments and/or separate the logic of this function. This is up for discussion 😊

Requirements
Golang basic level.

@noaabarki noaabarki added enhancement New feature or request up for grabs Looking for a contributor to take this task labels Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request up for grabs Looking for a contributor to take this task
Projects
None yet
Development

No branches or pull requests

1 participant