Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [GPU Logic Bug] SELECT -0.0 FROM <table> brings Error #1347

Open
qwebug opened this issue Oct 18, 2024 · 1 comment
Open

[BUG] [GPU Logic Bug] SELECT -0.0 FROM <table> brings Error #1347

qwebug opened this issue Oct 18, 2024 · 1 comment
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer

Comments

@qwebug
Copy link

qwebug commented Oct 18, 2024

What happened:

SELECT -0.0 FROM <table> brings different results, when using CPU and GPU.

What you expected to happen:

It is the same result, when using CPU and GPU.

Minimal Complete Verifiable Example:

import pandas as pd
import dask.dataframe as dd
from dask_sql import Context

c = Context()

df0 = pd.DataFrame({
    'c0': [0],
})
t0 = dd.from_pandas(df0, npartitions=1)

c.create_table('t0', t0, gpu=False)
c.create_table('t0_gpu', t0, gpu=True)

print('CPU Result:')
result1 = c.sql("SELECT -0.0 FROM t0").compute()
print(result1)

print('GPU Result:')
result2 = c.sql("SELECT -0.0 FROM t0_gpu").compute()
print(result2)

Result:

CPU Result:
   Float64(-0)
0         -0.0
GPU Result:
   Float64(-0)
0          0.0          

Anything else we need to know?:

Environment:

@qwebug qwebug added bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer labels Oct 18, 2024
@griffith-maker
Copy link

The issue has been fixed in Dask-sql version 2024.5.0, and you can try again to confirm it.
Thanks for @qwebug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting triage by a dask-sql maintainer
Projects
None yet
Development

No branches or pull requests

2 participants