Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to HTTPS #12

Open
orta opened this issue Jul 6, 2016 · 18 comments
Open

Move to HTTPS #12

orta opened this issue Jul 6, 2016 · 18 comments

Comments

@orta
Copy link
Member

orta commented Jul 6, 2016

Cloudflare

@KrauseFx KrauseFx self-assigned this Jul 6, 2016
@orta
Copy link
Member Author

orta commented Jul 7, 2016

screen shot 2016-07-07 at 14 40 26

Looks like this isn't doable on .systems domains

screen shot 2016-07-07 at 14 40 50

:(

@k0nserv
Copy link
Member

k0nserv commented Aug 22, 2016

DNSSEC isn't required for HTTPS is it?

@orta
Copy link
Member Author

orta commented Aug 22, 2016

for cloudflare free DNS it is

@k0nserv
Copy link
Member

k0nserv commented Aug 22, 2016

Ah, okay :(

@connorshea
Copy link

connorshea commented Sep 4, 2016

@orta @k0nserv GitLab Pages has SSL support by way of Let's Encrypt (or any other SSL cert provider, though I like LE), if you have any interest: https://about.gitlab.com/2016/04/11/tutorial-securing-your-gitlab-pages-with-tls-and-letsencrypt/

I can understand not wanting to move off GitHub of course :)

@orta
Copy link
Member Author

orta commented Sep 4, 2016

I do have interest, and I do need to learn how to use lets encrypt for CocoaPods, I should also try improve my GitLab foo. So that could all work together quite nicely.

@k0nserv
Copy link
Member

k0nserv commented Sep 4, 2016

One upside of that is that we'll end up with Danger running both for GitHub and GitLab which will help us detect issues and prevent drifting towards GitHub first. Would probably want to use GitLabCI in that case though

@orta
Copy link
Member Author

orta commented Sep 4, 2016

Aye, I've taken a stab at this, https://gitlab.com/danger-systems/danger.systems/ - if I can get this all working, I'll move the danger.systems repo over permanently.

@orta
Copy link
Member Author

orta commented Sep 4, 2016

Will accept anyone who applies to the group too, couldn't get danger alas

@connorshea
Copy link

@orta if it's not being used by someone else I can see about getting you the danger group :)

@orta
Copy link
Member Author

orta commented Sep 4, 2016

Awesome, it might be, so no expectations from my side

@orta
Copy link
Member Author

orta commented Sep 5, 2016

OK, so we've moved fully to GitLab pages, but I'm not adding letsencrypt yet. it looks like for now it requires re-creating the certs every 90 days manually in order for HTTPS to stay working, I'd rather not let links start failing because I needed to do some manual work.

I've +1'd this issue around that, https://gitlab.com/gitlab-org/gitlab-ee/issues/474

@connorshea
Copy link

@orta oh, sorry if I was unclear about it being manual. I definitely didn't mean to mislead. D:

@connorshea
Copy link

And the links should still work, they'll just redirect to HTTP if I remember correctly. There's no enforcement of HTTPS with HSTS or anything. I could be wrong, though.

@orta
Copy link
Member Author

orta commented Sep 5, 2016

It's no problem, it's the current status quo from GH-pages which I was going to live with, and I don't think you mis-sold me 💃

I just don't think I can rely on giving myself a "do this every 90 days" task, 1 year, 2 years, I can do, but they add up.

Well, I've got the certs set up any way, so I may as well try it for the 90 days and see when it expires

@orta
Copy link
Member Author

orta commented Sep 5, 2016

Cool, well, both http://danger.systems and https://danger.systems work now 👍

@connorshea
Copy link

@orta WRT getting the danger group name, just email [email protected] with the request to use the dormant group name. If it's inactive we'll ask the owner and if we see no response in two weeks you can have it :)

And please tell me if there's anything we can improve in GitLab, or open an issue!

@k0nserv
Copy link
Member

k0nserv commented Sep 5, 2016

Can the cert update not be automated? That is the intention from Let's Encrypts side with the short life certs after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants