misc: update browser icons #30790
Open
misc: update browser icons #30790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
requested changes
Dec 19, 2024
| @@ -63,11 +63,11 @@ | |||
| :disabled="autStore.isRunning" | |||
| > | |||
| <template #heading> | |||
| <img | |||
| <component | |||
There was a problem hiding this comment.
This conditional logic is repeated in several places - can it be abstracted to a new component?
There was a problem hiding this comment.
Are you referring to this conditional logic?
:is="allBrowsersIcons[selectedBrowser.displayName?.toLowerCase()] || allBrowsersIcons.generic"
That was already there before just under the src prop:
:src="allBrowsersIcons[selectedBrowser.displayName] || allBrowsersIcons.generic"
cypress
|
|||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/browser_icon_updates
|
| Run status |
|
| Run duration | 35m 34s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
7
|
Flaky
|
0
|
Pending
|
377
|
Skipped
|
0
|
Passing
|
6134
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
39.04%
|
|
|---|---|
|
Untested elements
|
198
|
|
Tested elements
|
130
|
Accessibility
93.68%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
1 moderate
2 minor
|
|
Failed elements
|
726
|
Tests for review
gql-components/topnav/UpdateCypressModal.cy.tsx • 0 failed tests • frontend-shared-ct
| Test | Artifacts | |
|---|---|---|
The first 5 failed specs are shown, see all 1179 specs in Cypress Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
Verify the icons are correct.
How has the user experience changed?
Browser selection:
Open mode header and dropdown:
Debug:
Run mode header:
PR Tasks
cypress-documentation?type definitions?