fix: error loading config file with node 22.12.0 #30730
Merged
+33
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/experiment/esm
|
| Run status |
|
| Run duration | 18m 48s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
949
|
Skipped
|
0
|
Passing
|
4679
|
| View all changes introduced in this branch ↗︎ | |
mschile
changed the title
|
Looks good to me. |
mschile
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Approving for @ryanthemanuel. I wrote the code but since he opened the initial PR, he is not able to directly approve the PR.
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Starting with node 22.12.0, experimental-require-module is now enabled by default which may cause an error loading the config file if it is loaded as an ESM.
Steps to test
Using Node
22.12.0, setup a typescript project withtype: 'modulein thepackage.json. In thecypress.config.tsfile, ensure to use typescript syntax, such as:How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?