Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cac_get_cuny_campuses() function undefined #15

Open
iwkse opened this issue Jun 3, 2022 · 3 comments
Open

cac_get_cuny_campuses() function undefined #15

iwkse opened this issue Jun 3, 2022 · 3 comments

Comments

@iwkse
Copy link

iwkse commented Jun 3, 2022

Where is that function defined?

@boonebgorges
Copy link
Member

Hello - It's defined in other parts of our private repo structure. Sorry, I wasn't expecting anyone to try to use this plugin :-D

Here's a gist that shows you how the function works: https://gist.github.com/boonebgorges/b80c578e5b8e6045e2f6a64223811472

@iwkse
Copy link
Author

iwkse commented Jun 3, 2022

Oh thank you :-)
I was working it around making it calls the get_campuses() function from the Course class and handle it from the admin. Any reason it his hard coded like that?

@boonebgorges
Copy link
Member

On https://commons.gc.cuny.edu we need a centralized store of campus data because it's used in a bunch of different places, not just alongside cac-courses. In this case, the cac_course_campus is just a storage mechanism for the course-campus relationship - I'm not relying on it for information about the campuses themselves.

I'd be happy to remove the hardcoded references and replace them with add_filters() calls, if you feel like writing the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants