Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use airtable request fields in place of hardcoded keys #124

Open
piratefsh opened this issue Aug 1, 2020 · 1 comment · May be fixed by #153
Open

Use airtable request fields in place of hardcoded keys #124

piratefsh opened this issue Aug 1, 2020 · 1 comment · May be fixed by #153
Assignees
Labels
good first issue Good for newcomers webapp

Comments

@piratefsh
Copy link
Collaborator

Summary

We have a number of keys used to access Airtable objects that are hardcoded in the webapp. Example:

We should replace this hardcoded keys with the centralized list of Airtable keys here:

const fields = (exports.fields = {

This should be importable from the webapp.

Bonus

Get ~airtable alias working within the webapp. I believe it's only possible to import via relative paths at the moment. This issue was faced here: https://github.com/crownheightsaid/mutual-aid-app/pull/104/files#r459213347

Why

This is important to prevent inconsistencies as well as typos that may lead to bugs! This app is also used by other mutual aids and having these keys in a centralized place makes it easy for them to adapt this app for their airtable, much like with string translations.

@piratefsh piratefsh added good first issue Good for newcomers webapp labels Aug 1, 2020
@piratefsh piratefsh assigned piratefsh and unassigned piratefsh Aug 1, 2020
@mjmaurer
Copy link
Contributor

mjmaurer commented Aug 7, 2020

Re: the bonus :::

I think alias should work (minus the tilde) as of #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers webapp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants