Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy: Maintenance support for SQLAlchemy 1.3 #108

Closed
amotl opened this issue Dec 22, 2022 · 1 comment · Fixed by crate/crate-python#497
Closed

SQLAlchemy: Maintenance support for SQLAlchemy 1.3 #108

amotl opened this issue Dec 22, 2022 · 1 comment · Fixed by crate/crate-python#497

Comments

@amotl
Copy link
Member

amotl commented Dec 22, 2022

Hi.

While working on support for SQLAlchemy 2.0 on behalf of crate/crate-python#485 and crate/crate-python#488, we discovered that the updated code will no longer be compatible with SQLAlchemy 1.3.

ImportError: cannot import name 'declarative_base' from 'sqlalchemy.orm'
sqlalchemy.exc.ArgumentError: columns argument to select() must be a Python list or other iterable

While SQLAlchemy 1.3 is effectively EOL, we may still want to keep supporting it for a while for users of the CrateDB dialect.

If you agree, we will have to come up with a proper release and deprecation plan.

My proposal, already briefly discussed with @seut, would be to run a 0.30.0 maintenance release, which adds a corresponding warning for users who are still on SA13. Then, we would move on by integrating the SA20 changes, and probably release them with a crate-python 1.0.0 version (maybe after running a few 1.0.0bX releases). In this manner, the 1.x series will support SA14 and SA20, while the 0.x series would still be able to receive maintenance patches, and keeps supporting SA13.

With kind regards,
Andreas.

@amotl
Copy link
Member Author

amotl commented Dec 23, 2022

Inspired by comments from the upstream authors at sqlalchemy/sqlalchemy#8631 (comment), crate/crate-python#497 retains compatibility with SQLAlchemy 1.3.

@amotl amotl closed this as completed Dec 23, 2022
@amotl amotl transferred this issue from crate/crate-python Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant