Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendEmailHandler sending mails with incorrect sender (minor fix) #263

Open
DennisOng opened this issue Nov 2, 2013 · 0 comments
Open

SendEmailHandler sending mails with incorrect sender (minor fix) #263

DennisOng opened this issue Nov 2, 2013 · 0 comments

Comments

@DennisOng
Copy link

In line 71 of handlers.py (in SendEmailHandler) , the condition

if sender != ' ' will match any specified sender, and as a result, the sender email will either be replaced by self.app.config.get('contact_sender') or "%s <no-reply@%s.appspotmail.com>" % (app_id, app_id) ......

eg: If I want to use "hello@%s.appspotmail.com" % (app_id) as the sender email, it will not allow me although it should be a valid sender.

maybe sender == ' ' should raise an exception instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant