Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit-test-- ensure data is a particular number of hours. #164

Open
dwreeves opened this issue Feb 7, 2021 · 0 comments
Open

Unit-test-- ensure data is a particular number of hours. #164

dwreeves opened this issue Feb 7, 2021 · 0 comments
Labels
data Anything related to databases, data management, stuff that is heavily focused in the data directory. low priority Issues we are not currently focusing on, either because it has a lot of blockers or isn't important. testing Adding unit-tests and integration tests.

Comments

@dwreeves
Copy link
Collaborator

dwreeves commented Feb 7, 2021

Basically this issue falls into two parts.

First, make sure the hours limitation works. It has pretty predictable behavior:

(venv) daniel@mbp flagging % psql -d flagging

flagging=# select max(time), min(time) from hobolink;
         max         |         min         
---------------------+---------------------
 2021-02-07 09:40:00 | 2021-01-31 09:50:00
(1 row)

flagging=# select max(time), min(time) from usgs;
         max         |         min         
---------------------+---------------------
 2021-02-07 09:30:00 | 2021-01-31 09:00:00
(1 row)

flagging=# select max(time), min(time) from processed_data;
         max         |         min         
---------------------+---------------------
 2021-02-07 09:00:00 | 2021-01-31 10:00:00
(1 row)

flagging=# select max(time), min(time) from model_outputs;
         max         |         min         
---------------------+---------------------
 2021-02-07 09:00:00 | 2021-01-31 10:00:00
(1 row)

This is based on live data, not the mock data.

That's the second part of this issue. I currently have 1 test that uses live data, and the rest can use mock data. Am I doing a good job at isolating the two categories of tests? There might be a better way of doing this than what I'm currently doing. Need to look into that.

@dwreeves dwreeves added data Anything related to databases, data management, stuff that is heavily focused in the data directory. testing Adding unit-tests and integration tests. low priority Issues we are not currently focusing on, either because it has a lot of blockers or isn't important. labels Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Anything related to databases, data management, stuff that is heavily focused in the data directory. low priority Issues we are not currently focusing on, either because it has a lot of blockers or isn't important. testing Adding unit-tests and integration tests.
Projects
None yet
Development

No branches or pull requests

1 participant