Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexs links link to the same page, not the link it matches #434

Open
C-Loftus opened this issue Aug 29, 2024 · 1 comment
Open

Regexs links link to the same page, not the link it matches #434

C-Loftus opened this issue Aug 29, 2024 · 1 comment

Comments

@C-Loftus
Copy link

Thank you for your work on codehike. Just tried out v1 and it is great with Docusaurus.

I am running into an issue with link annotations. https://codehike.org/docs/code/link mentions we can use regexes for links. However, the links that match end up linking to the same page. This occurs on the example in the docs.

I wasn't sure if there is additional syntax but could not find it elsewhere. Happy to submit a PR to the docs if this is something I am missing.

Here I hover over the github link but the link shows it linking to the same site

image

Reproduced this myself locally as well.
image

@pomber
Copy link
Contributor

pomber commented Aug 29, 2024

You are right, thanks.

There's a feature missing where the regex match is passed to the annotation, in the case of links the match then becomes the href. I have that on my todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants