Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Judges' view should have the basic time bars #10

Open
timparenti opened this issue Nov 14, 2018 · 4 comments
Open

Judges' view should have the basic time bars #10

timparenti opened this issue Nov 14, 2018 · 4 comments

Comments

@timparenti
Copy link
Member

The Judges' view should have the basic time bars above the Game panel, although perhaps significantly smaller than on the main timer page. (Most of the other information is already "visualized" by simply appearing below the panel inputs.)

This can help reassure the operator that their incantations are, in fact, functioning as intended, without having to switch to another tab to see so.

@michaelfelixmurphy
Copy link
Member

This is a good and very reasonable idea. Currently the main page is using Vue and the judges page is still old school. This will be very easy to do when I eventually migrate the judges page to Vue, but until then it would involve a lot of code duplication. For now, I'd say stick with two tabs. Luckily they're both reactive :)

@timparenti
Copy link
Member Author

Perhaps, if colored badges on the tabs are implemented as part of #13, that could be part of the solution for this one, too. Anything that provides the administrative user with a clearer overview of the state of everything under their purview.

@michaelfelixmurphy
Copy link
Member

This is really just a matter of doing a lot of refactoring to convert the judges game tab from it's current jquery mess to Vue, and to find a way to effectively reuse the Vue time bars from the main page, without a full proper build system. For now I'm going to prioritize so of the other new features.

If I were to add badges (I will for the device tab), what would you want badged on the game tab?

@timparenti
Copy link
Member Author

timparenti commented Mar 2, 2019

Without looking too much into the codebases to see what's already done elsewhere, some version of the following, insofar as it's logically/visually consistent with other behavior, seems logical:

  • Grey "No game" badge if no game configured
  • Blue countdown during setup, perhaps of the abbreviated form "n|xx:xx" (where n is the game number)
  • Green (overall) countup during gameplay, similar to above
    • Turn red if/when a game runs to full time?
  • Maybe yellow for other weird cases, e.g., start time in future, with some symbol/indicator to go look into it in more detail.

Since it's not really possible for the timers to "pause", per se, there shouldn't be a need to indicate the difference between a paused and running timer, except when a game goes to full time, in which case it effectively "caps out".

In particular, I think trying to shoehorn other data, like the scores and flag counts, in the badge is unnecessary. We just need something to be able to tell at a glance that yes, the game timers are running as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants