Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the VCAP_APPLICATION version and application_version attributes #3544

Open
georgethebeatle opened this issue Oct 22, 2024 · 0 comments
Labels
bug Something isn't working tbd

Comments

@georgethebeatle
Copy link
Member

georgethebeatle commented Oct 22, 2024

Background

We should support the version and application_version attrubutes of the VCAP_APPLICATOIN env var.

Acceptance

GIVEN I push an app that dumps the envirionment to Korifi

WHEN I access the app
THEN I can see version and application_version attributes in the VCAP_APPLICATION env var

WHEN I restart the app
THEN I can see that version and application_version have changed

Dev Notes

  • On CF for VMs the version and application_version in the VCAP_APPLICATION env var are set to the process version.
  • Looking at the cloud controller code there are certain rules that dictate when the process version should be changed.
  • As of today the only rule that applies is the transition of the process from STOPPED to STARTED. These statuses look like they refer to the process, not the app. We do not have process statuses in korifi.
  • Can we generate the version in the app revision webhook?

Output from mel-c

# from an ssh session on the app container
$ echo $VCAP_APPLICATION | jq .
{
  "version": "8f6e2e8a-93f3-490c-8021-462172cb77c7",
  "application_version": "8f6e2e8a-93f3-490c-8021-462172cb77c7"
}
❯ cf curl /v3/processes | jq '.resources[].version'
"8f6e2e8a-93f3-490c-8021-462172cb77c7"
"dc1003cf-4133-42d0-9428-c3f59c8cc302"
@georgethebeatle georgethebeatle added the bug Something isn't working label Oct 22, 2024
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tbd
Projects
Status: 🧊 Icebox
Development

No branches or pull requests

1 participant