Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change autogenerated Javadoc for Tiers #81

Open
carlosuc3m opened this issue Oct 17, 2024 · 16 comments
Open

Change autogenerated Javadoc for Tiers #81

carlosuc3m opened this issue Oct 17, 2024 · 16 comments

Comments

@carlosuc3m
Copy link
Member

HEllo @StRigaud ,
Deployment seems to be almost ready but I am finding an error generating the JAvadoc, which is required to deploy to scijava.

The tag @see cannot be used together with links. The Tier generator uses it for every tier:

* @see https://clij.github.io/clij2-docs/reference_absolute

The link needs to be embedded in html:
instead of
@see https://clij.github.io/clij2-docs/reference_absolute
we need to use
@see <a href="https://clij.github.io/clij2-docs/reference_absolute">reference_absolute</a>

@StRigaud
Copy link
Member

Ffs ...

Okay, I will remove the tag for now. It will be easier to deal with this later

StRigaud added a commit to clEsperanto/gencle that referenced this issue Oct 17, 2024
@StRigaud StRigaud mentioned this issue Oct 17, 2024
@StRigaud
Copy link
Member

I merged a fix but the issue is not solved, I will find an alternative later when more urgent issue are done

@carlosuc3m
Copy link
Member Author

carlosuc3m commented Oct 17, 2024

There are more Javadoc errors that stop the deploymnet (mvn does not tell you all at once).
Now the issue is with using &, > and <.
They should be:

& -> &amp;
> -> &gt;
< -> &lt;
I can have a look at the autogenerator for more possible conflicts

@StRigaud
Copy link
Member

So:

  • & var -> &var
  • var > -> var >
  • < var -> <var

is it correct?

@StRigaud
Copy link
Member

@carlosuc3m can you actually point to a piece of code to correct / an example. I don't understand well the issue

@StRigaud
Copy link
Member

Ha got it, the charactere in the JavaDoc need to be replace by code charactere

@carlosuc3m
Copy link
Member Author

carlosuc3m commented Oct 17, 2024

Yess sorry. Basically in javadocs there are some characters reserved for certain things that cannot be used.
These special characters need to be substituted for their html equivalents

For example this line uses < which cannot be used for javadoc.

The line is:
* @return ArrayList<Float>

It should be

* @return ArrayList&lt;Float&gt;

So the mvn javadoc plugin recognises it

@StRigaud StRigaud mentioned this issue Oct 17, 2024
@StRigaud
Copy link
Member

I made a PR, the JavaDoc look like nothing but hopefully its ok

@carlosuc3m
Copy link
Member Author

carlosuc3m commented Oct 17, 2024

In this line

Instead of
* If it was > 0, it will be 1.

do
* If it was &gt; 0, it will be 1.

@carlosuc3m
Copy link
Member Author

Also we might need javadoc for Javacpp xd, lets see

@carlosuc3m
Copy link
Member Author

Also I am trying right now if it works but there is a difference between html and non-html <> use.

You can do
* <pre>f(x) = x</pre> For binary images, use binaryNot.

but you cannot do 5 > 4

@StRigaud
Copy link
Member

I simply did a full character replacement, if it work I am fine and we will see later for a cleaner writing

@StRigaud
Copy link
Member

Also we might need javadoc for Javacpp xd, lets see

That would be annoying

@carlosuc3m
Copy link
Member Author

It builds the javadoc now without any issue 🥳

@StRigaud
Copy link
Member

Not urgent but for later, what can I use instead of the @see tag to display links? or do I need to convert the links to html ?

@carlosuc3m
Copy link
Member Author

It looks like it:
The correct link formatting is the following:
@see <a href="https://clij.github.io/clij2-docs/reference_absolute">reference_absolute</a>

StRigaud added a commit to clEsperanto/gencle that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants