Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientSetup Enhancements - Parameterize script to allow for additional flexibility #240

Open
2 tasks done
ryanrichter94 opened this issue Mar 20, 2024 · 4 comments · May be fixed by #284
Open
2 tasks done

ClientSetup Enhancements - Parameterize script to allow for additional flexibility #240

ryanrichter94 opened this issue Mar 20, 2024 · 4 comments · May be fixed by #284
Assignees
@steviecoaster
Labels
0 - _Triaging New tickets that need to be hashed out a bit more before they hit the backlog. Enhancement Enhancements are things that are improvements or features.

Comments

@ryanrichter94
Copy link
Member

ryanrichter94 commented Mar 20, 2024 •
edited by steviecoaster
Loading

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

Through customer interaction these are the nice additions we feel would be well received to edit within ClientSetup

  • Allow entry of Passing domain credential for agent installation
  • Allow toggle of ContextMenu on or off with extension install
  • Make adding additional packages to ClientSetup easier
  • Make adding additional chocolatey sources easier

Describe The Solution. Why is it needed?

These enhancements would make the ClientSetup script more flexible by providing parameters to the script to support more customizable installs.

Additional Context

No response

Related Issues

No response
@ryanrichter94 ryanrichter94 added the Enhancement Enhancements are things that are improvements or features. label Mar 20, 2024
@ryanrichter94 ryanrichter94 added 0 - _Triaging New tickets that need to be hashed out a bit more before they hit the backlog. labels Jun 28, 2024
@steviecoaster steviecoaster changed the title ClientSetup Enhancements ClientSetup Enhancements - Parameterize script to allow for additional flexibility Sep 27, 2024
@steviecoaster
Copy link
Contributor

This could be done with additional parameters:

[Parameter()]
[Hashtable[]]
$AdditionalPackages,

[Parameter()]
[Hashtable[]]
$AdditionalConfiguration

We could then just act on it at the end of ClientSetup:

if($AdditionalPackages){
  #action here
}

if($AdditionalConfiguration){
  #Action here
}

@steviecoaster steviecoaster self-assigned this Oct 17, 2024
@JPRuskin
Copy link
Member

If doing AdditionalPackages can I suggest that we trigger the Jenkins job (like we do in Azure / Ansible) rather than adding further logic?

See: https://github.com/chocolatey/c4b-azure/blob/main/source/Initialise-C4B.ps1#L174-L184

@steviecoaster
Copy link
Contributor

If doing AdditionalPackages can I suggest that we trigger the Jenkins job (like we do in Azure / Ansible) rather than adding further logic?

See: https://github.com/chocolatey/c4b-azure/blob/main/source/Initialise-C4B.ps1#L174-L184

This is on the client side. When setting up a workstation with C4b this would allow you to add additional things to be installed, on top of what is predefined in the ClientSetup.ps1. At this stage, trigger the jenkins job doesn't quite make sense?

@JPRuskin
Copy link
Member

Ah, very true - for some reason I was thinking of that being similar to the additional packages in Azure. Disregard me!

steviecoaster added a commit to steviecoaster/choco-quickstart-scripts that referenced this issue Dec 4, 2024
@steviecoaster
(chocolatey#240) Parameterize setup
8ceddd5 
This script adds parameterization to the ClientSetup.ps1 script that is
hosted within the Nexus repository. It also adds parameterization to the
registration script that is executed on a client so you can customize the
installation.
@steviecoaster steviecoaster linked a pull request Dec 4, 2024 that will close this issue
Open
10 tasks
steviecoaster added a commit to steviecoaster/choco-quickstart-scripts that referenced this issue Dec 4, 2024
@steviecoaster
(chocolatey#240) Parameterize setup
4ff5276 
This script adds parameterization to the ClientSetup.ps1 script that is
hosted within the Nexus repository. It also adds parameterization to the
registration script that is executed on a client so you can customize the
installation.
steviecoaster added a commit to steviecoaster/choco-quickstart-scripts that referenced this issue Dec 4, 2024
@steviecoaster
(chocolatey#240) Parameterize setup
c2d1bb6 
This script adds parameterization to the ClientSetup.ps1 script that is
hosted within the Nexus repository. It also adds parameterization to the
registration script that is executed on a client so you can customize the
installation.
steviecoaster added a commit to steviecoaster/choco-quickstart-scripts that referenced this issue Dec 4, 2024
@steviecoaster
(chocolatey#240) Parameterize setup
78f53cf 
This script adds parameterization to the ClientSetup.ps1 script that is
hosted within the Nexus repository. It also adds parameterization to the
registration script that is executed on a client so you can customize the
installation.
steviecoaster added a commit to steviecoaster/choco-quickstart-scripts that referenced this issue Dec 6, 2024
@steviecoaster
(chocolatey#240) Parameterize setup
c1f8e77 
This script adds parameterization to the ClientSetup.ps1 script that is
hosted within the Nexus repository. It also adds parameterization to the
registration script that is executed on a client so you can customize the
installation.
steviecoaster added a commit to steviecoaster/choco-quickstart-scripts that referenced this issue Dec 11, 2024
@steviecoaster
(chocolatey#240) Parameterize setup
86402af 
This script adds parameterization to the ClientSetup.ps1 script that is
hosted within the Nexus repository. It also adds parameterization to the
registration script that is executed on a client so you can customize the
installation.
steviecoaster added a commit to steviecoaster/choco-quickstart-scripts that referenced this issue Dec 11, 2024
@steviecoaster
(chocolatey#240) Parameterize setup
9e64d22 
This script adds parameterization to the ClientSetup.ps1 script that is
hosted within the Nexus repository. It also adds parameterization to the
registration script that is executed on a client so you can customize the
installation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steviecoaster steviecoaster

Labels
0 - _Triaging New tickets that need to be hashed out a bit more before they hit the backlog. Enhancement Enhancements are things that are improvements or features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#240) Parameterize setup steviecoaster/choco-quickstart-scripts
3 participants
@JPRuskin @steviecoaster @ryanrichter94