Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: referencing a file above the cwd / checkly config location fails #800

Open
jan-osch opened this issue Jul 20, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@jan-osch
Copy link
Member

Node.js version

16.19.1

NPM version

8.19.3

@checkly/cli version

4.0.12

Steps to reproduce

Repro repo:
https://github.com/checkly/cli-playground-jan/tree/issue-file-outside-temp-dir

What is expected?

The check should pass

What is actually happening?

Check is failing because it cannot create a dependency file outside of the temp directory

Any additional comments?

No response

@jan-osch jan-osch added the bug Something isn't working label Jul 20, 2023
@nahuelon
Copy link
Contributor

@umutuzgur , as far I could investigate we should adjust dependencies path and make all to start from the path of the spec file. If now, the lambda-runner won't be able to handle ../../ path from the /tmp/... where the check runs.
If we adjust the dependency path we have to modify the import path (in the spec file) adjusting it using a relative path starting from the spec file folder. I can create a draft PR to illustrate what I mean, but I would like to know if we agree in support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants