Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Refactor gRPC instrumentation tests to make them independent from record order #501

Open
hekike opened this issue May 6, 2019 · 1 comment

Comments

@hekike
Copy link
Contributor

hekike commented May 6, 2019

Is your feature request related to a problem? Please describe.
No, it's a testing ergonomic issue

Describe the solution you'd like
gRPC instrumentation tests depend on record order which makes testing challenging.

Describe alternatives you've considered
I'd suggest ordering spans before asserting on them.

@mayurkale22
Copy link
Member

@hekike Thanks for reporting this, PR welcome ☺️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants