Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add ConfigStream behavior from OCAgent #367

Open
justindsmith opened this issue Feb 27, 2019 · 1 comment
Open

Add ConfigStream behavior from OCAgent #367

justindsmith opened this issue Feb 27, 2019 · 1 comment

Comments

@justindsmith
Copy link
Contributor

The OC Agent has defined a grpc Config stream in their proto, which is used to push configuration changes (sample policy, etc) from the agent to a client. This allows for a centralized configuration.

The definition of the features is currently only defined in the trace_service.proto.

The logic fits inside the package/opencensus-exporter-ocagent library, which is already using the grpc Export call.

A rough, non-working implementation was included in commit c2764ae6c18a6ff3cefc9a9738ea53f4e7e5af07 and removed in commit 471470592e45a28f25bc061bb8161ab540936448 for reference.

@justindsmith
Copy link
Contributor Author

Note that - to my knowledge - Config stream support is not yet included in any other languages exporter, so we are not "behind" from this perspective.

We should probably wait for @pjanotti and @songy23 to give the go ahead before re-enabling this functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants