Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong blocked state #59

Open
beliaev-maksim opened this issue Apr 19, 2023 · 2 comments
Open

wrong blocked state #59

beliaev-maksim opened this issue Apr 19, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@beliaev-maksim
Copy link
Member

self.unit.status = BlockedStatus(

here should not be blocked status. We do not expect any action from human operator

@ca-scribner
Copy link
Contributor

I don't think BlockedStatus is incorrect here.

The trouble here is that we don't know why it is blocked - this could be an incorrect image, network connectivity problems, etc. Basically everything that can go wrong with a StatefulSet. Because of this, this state may arise for something transient (slow container start due to a slow network) or something requiring user intervention (no network connectivity, etc). So we can either say WaitingStatus even though it might never resolve, or BlockedStatus even though it might fix itself.

@beliaev-maksim
Copy link
Member Author

@ca-scribner I am good to keep Blocked as soon as we provide clear instruction for humans what to do

ideally, we need to think how to differentiate between different causes of issues

@NohaIhab NohaIhab added the bug Something isn't working label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants