Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add self hosted gitlab to integration tests #13

Open
cafkafk opened this issue Oct 30, 2023 · 2 comments
Open

feat: add self hosted gitlab to integration tests #13

cafkafk opened this issue Oct 30, 2023 · 2 comments

Comments

@cafkafk
Copy link
Owner

cafkafk commented Oct 30, 2023

In f94d4d5, I introduced some integration tests that ensure the most important endpoint is tested. However, due to being unable to find a self hosted gitlab I could register on, I haven't set up testing for that.

@algernon
Copy link
Collaborator

Regarding testing: how do you feel about mocking the APIs of the different forges with something like mockito, and running tests against those? At least for the self-hostable forges, this would allow testing without access to the outside network, and without having to register and host a test project on either of them. The downside, of course, is that the mocked APIs would have to be faithful enough for the tests to make sense, and would require a bit of extra maintenance.

@cafkafk
Copy link
Owner Author

cafkafk commented Oct 30, 2023

I thought if we went in that direction, we'd go for the nixpkgs style nixos tests, then we wouldn't even need to mock the self-hostable forges, which would be very cool (and allow us to run the tests inside the flake check). The only thing that has stopped me from doing that is I'm not really very familiar with nixos tests, and those integration tests I made just now are just a temporary solution we can keep around until something better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants