Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating rquickjs from 0.6.1 to 0.8.1 #861

Open
jeffcharles opened this issue Dec 10, 2024 · 0 comments
Open

Updating rquickjs from 0.6.1 to 0.8.1 #861

jeffcharles opened this issue Dec 10, 2024 · 0 comments

Comments

@jeffcharles
Copy link
Collaborator

jeffcharles commented Dec 10, 2024

I'm going to document the issues I ran into trying to update rquickjs here.

  1. Turning on the SIMD implementation for JSON seems to cause at least one test262 failure
  2. Fuel increases in tests
  3. We still need to investigate if there are breaking changes to the QuickJS bytecode so we know whether we need to cut new major versions of the javy and javy-plugin-api crates and increment the plugin version.

The test262 failure I'm seeing is in the file crates/javy/test262/test/built-ins/JSON/stringify/value-bigint.js and the error message is Expected a TypeError to be thrown but no exception was thrown at all.

For the fuel increases:

Test Target fuel New fuel Increase %
test_encoding 258197 270087 4.6%
test_exported_functions 61404 63518 3.4%
test_identity 47773 50760 6.3%
test_empty 22590 24554 8.7%
test_exported_default_arrow_fn 39004 40038 2.7%
test_exported_default_fn 39951 40933 2.5%
test_fib 64681 71302 10.2%
test_logging_with_redirect 35007 37709 7.8%
test_logging_without_redirect 36641 37592 2.6%
test_recursive_fib 69306 76848 10.9%
test_readme_script 254503 271684 6.8%
test_str 146027 154404 5.7%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant