Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotation mark in accessory name prevents it from being added #192

Open
joeshaw opened this issue Jan 3, 2021 · 0 comments
Open

Quotation mark in accessory name prevents it from being added #192

joeshaw opened this issue Jan 3, 2021 · 0 comments

Comments

@joeshaw
Copy link

joeshaw commented Jan 3, 2021

Create an accessory with its accessory.Info Name field containing a quotation mark. (For me, it was 32" Roku TV.) Attempting to add the device times out. I expect this is due to an escaping problem of some sort with DNS-SD.

Currently hc converts spaces to underscores. If I add a similar replacement that strips the quotation mark, things work fine. But I'm not sure if this is the right fix.

With this replacement in place, when I add the accessory and I'm asked to name it, it doesn't have the quotation mark. I tried to add it back in and Home.app said that names cannot contain special characters.

Possibly related to #141.

@joeshaw joeshaw changed the title Quotation marks in accessory name prevents it from being added Quotation mark in accessory name prevents it from being added Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant