pg-connection-string: Shouldn't idleTimeoutMillis be considered? For pool usage patterns?

[deostroll]

https://github.com/brianc/node-postgres/blob/master/packages/pg-connection-string/index.js

👆 The code here is not setting anything with respect to idleTimeoutMillis. Other parameters such as user, password, ssl, etc are set.

Therefore when using connection string usage - what is the actual design? Should the developer pass the connectionString and idleTmeoutMillis together for pool configurations? Or should the developer set in the connectionString itself.

I don't see anything relating to idleTimeoutMillis here either: https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING-URIS

Please advice.

[hjr3]

The spec is here: https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING-URIS

We can set idleTimeoutMillis in the query params, but that will give us a string instead of a number.

Looking at

node-postgres/packages/pg/lib/connection-parameters.js

Lines 107 to 120 in 95d7e62

	this.idle_in_transaction_session_timeout = val('idle_in_transaction_session_timeout', config, false)
	this.query_timeout = val('query_timeout', config, false)
	if (config.connectionTimeoutMillis === undefined) {
	this.connect_timeout = process.env.PGCONNECT_TIMEOUT || 0
	} else {
	this.connect_timeout = Math.floor(config.connectionTimeoutMillis / 1000)
	}
	if (config.keepAlive === false) {
	this.keepalives = 0
	} else if (config.keepAlive === true) {
	this.keepalives = 1
	}

it should still work though.

I do not see idleTimeoutMills in the code base or https://node-postgres.com/apis/client docs. Maybe you meant connectionTimeoutMillis?

const config = parse('postgres://user:pw@host/db?connectionTimeoutMillis=100');
assert(config.connectionTimeoutMillis === '100'); // true

and will be honored here:

node-postgres/packages/pg/lib/connection-parameters.js

Lines 110 to 114 in 95d7e62

	if (config.connectionTimeoutMillis === undefined) {
	this.connect_timeout = process.env.PGCONNECT_TIMEOUT || 0
	} else {
	this.connect_timeout = Math.floor(config.connectionTimeoutMillis / 1000)
	}