Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name is misleading this is for images only #110

Open
ConnectedReasoning opened this issue Apr 4, 2019 · 2 comments
Open

name is misleading this is for images only #110

ConnectedReasoning opened this issue Apr 4, 2019 · 2 comments

Comments

@ConnectedReasoning
Copy link

Expected Behavior

It should allow for general content

Current Behavior

renders only images

Possible Solution

allow other html components to be displayed as bricks, change name to reflect the narrow image only scope of component.

Steps to Reproduce

replace images in bricks with other kinds of react components, like Text

Context (Environment)

Detailed Description

Possible Implementation

@brh55
Copy link
Owner

brh55 commented Apr 4, 2019

Excellent point. This really spawned from the limitations of managing images when trying to use flexbox to create a typical masonry layout due to the fact that you need dimensions prior to perform resizing.

With other elements such as text and views, a masonry layout is pretty easy to accomplish with just the use of flexbox and standard column layouts i.e.: [row flex: [column 1][column2] ])

It's possible to expand the scope to other elements, however, some sort ordering will behave oddly due to the async nature, i.e: text will render first in the list no matter what. We just need to discuss the expectations of these behaviors and we should be able to implement it.

@bartzy
Copy link

bartzy commented Nov 23, 2019

@brh55 How is masonry layout with more than one column easy to accomplish with just using flexbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants