twitch.tv - video ads bypassing shields

[lukemulks]

Description

• Reported via BAT subreddit: https://www.reddit.com/r/BATProject/comments/8r3eke/i_just_opened_twitch_and_got_an_ad_does_brave_no/

• 3P video ads are bypassing Brave shields.

Steps to Reproduce

1. Go to https://www.twitch.tv/ninja or another streamer page.
2. Click to play video.
3. See ad.

Actual result:

Expected result:
No ads.

Reproduces how often:
Repro'd for 2 testers on first play 100% of the time.

Brave Version

about:brave info:

Brave: 0.22.810
V8: 6.7.288.43
rev: 8f30eeb
Muon: 7.0.6
OS Release: 10.0.16299
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.71

Reproducible on current live release:
yes

Additional Information

Twitch is detecting ad blocking, and passing kv param values via query string parameters in the twitch api calls:

example: https://api.twitch.tv/api/channels/ninja/access_token?adblock=true&need_https=true&oauth_token&platform=web&player_type=site

adblock=true

Observed Google's IMA SDK frame being called, which we should be blocking.

Need to test breakage when blocked.

https://imasdk.googleapis.com/js/core/bridge3.214.1_en.html

Suspect that the video player is configured for anti-ad blocking, with a proxied 1st party request for the ad.

Needs additional testing and investigation.

[GeetaSarvadnya]

1+ https://community.brave.com/t/twitch-tv-not-working-properly/25427

[chuckreynolds]

directed here from community forums ... this is evidently the problem with Twitch.tv streams being blacked out... no video or audio?

[aaron5523]

I noticed this too after I performed the upgrade. Tried the stream in Chrome, no issue, but of course, there are ads.

[aaron5523]

Although, I just tried with an older version of the browser on a different machine and I'm getting the same result. Tried a live stream, am seeing the streaming chat, but no video. Seems like maybe be on the twitch side changed something around

[Tomatoshadow2]

#14475 Here's the issue to follow, with streams not working at all.

[Brave-Matt]

+1 from Reddit: https://www.reddit.com/r/brave_browser/comments/9c4uh3/ad_slipped_through_on_twitch_while_shield_is_up/
EDIT: He's confirmed he's using live release and also is located in the Netherlands (regional info)

[Brave-Matt]

Another +1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/9fjowx/brave_doesnt_block_ads_on_twitch_anymore/

[Miyayes]

Addendum: Here is another report of the issue with more extensive investigation that was filed under the ad-block repository. (Could be merged together as it is somewhat a duplicate.)

brave-experiments/ad-block#135