Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC2] PlatformValues enum is incorrect in botocore shapes #3128

Closed
vemel opened this issue Feb 27, 2024 · 2 comments
Closed

[EC2] PlatformValues enum is incorrect in botocore shapes #3128

vemel opened this issue Feb 27, 2024 · 2 comments
Assignees
Labels
bug This issue is a confirmed bug. p2 This is a standard priority issue

Comments

@vemel
Copy link

vemel commented Feb 27, 2024

Describe the bug

In botocore shape PlatformValues enum has value Windows, while the actual return value is windows.

Expected Behavior

PlatformValues enum has [windows] value.

Current Behavior

PlatformValues enum has [Windows] value.

Reproduction Steps

Run any related method, e.g. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/create_fleet.html#

and check the response.

Possible Solution

Replace Windows with windows in PlatformValues

Additional Information/Context

No response

SDK version used

1.34.50

Environment details (OS name and version, etc.)

OS-independent

@vemel vemel added bug This issue is a confirmed bug. needs-triage This issue or PR still needs to be triaged. labels Feb 27, 2024
@vemel vemel changed the title EC2: PlatformValuesType enum is incorrect [EC2] PlatformValues enum is incorrect Feb 27, 2024
@vemel vemel changed the title [EC2] PlatformValues enum is incorrect [EC2] PlatformValues enum is incorrect in botocore shapes Feb 27, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this May 7, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added p2 This is a standard priority issue investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @vemel, thanks for reaching out and for your patience. I was able to reproduce this issue using CreateFleet. You are correct that there is a mismatch between what is documented (CreateFleetInstance structure and botocore enum both are uppercase) and what is returned. I've reached out to the service team to clarify what the intended behavior is here. In the meantime, as this is a service team issue, I've created a tracking issue (aws/aws-cli#9043) in our cross-SDK repository that you can refer to for future updates. Thanks!

@RyanFitzSimmonsAK RyanFitzSimmonsAK removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a confirmed bug. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants