configure.ac should check for lcms2 instead lcms

[JeanLucCoulon]

Hi,
configure.ac still mention lcms instead of lcms2

Patch attached
photoprint-lcms2-configure.zip

Regards

Jean-Luc

[archont00]

It is probably not enough:

In file included from ../profilemanager/lcmswrapper.h:5,
                 from imagesource.cpp:3:
../profilemanager/lcmswrapper_lcms1.h:22:10: fatal error: lcms.h: No such file or directory
 #include <lcms.h>
          ^~~~~~~~
compilation terminated.
make[2]: *** [imagesource.lo] Error 1

[hankschwie]

And even after changing that to lcms2.h make gives errors and fails:

CXX imagesource.lo In file included from ../profilemanager/lcmswrapper.h:5:0, from imagesource.cpp:3: ../profilemanager/lcmswrapper_lcms1.h: In constructor ‘CMSWhitePoint::CMSWhitePoint(int)’: ../profilemanager/lcmswrapper_lcms1.h:120:41: error: invalid conversion from ‘int’ to ‘cmsCIExyY*’ [-fpermissive] cmsWhitePointFromTemp(degk,&whitepoint); ^ ../profilemanager/lcmswrapper_lcms1.h:120:41: error: cannot convert ‘cmsCIExyY*’ to ‘cmsFloat64Number {aka double}’ for argument ‘2’ to ‘cmsBool cmsWhitePointFromTemp(cmsCIExyY*, cmsFloat64Number)’ ../profilemanager/lcmswrapper_lcms1.h: At global scope: ../profilemanager/lcmswrapper_lcms1.h:174:2: error: ‘LPGAMMATABLE’ does not name a type LPGAMMATABLE GetGammaTable() ^~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:179:2: error: ‘LPGAMMATABLE’ does not name a type LPGAMMATABLE gammatable; ^~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h: In constructor ‘CMSGamma::CMSGamma(float, bool)’: ../profilemanager/lcmswrapper_lcms1.h:160:4: error: ‘gammatable’ was not declared in this scope gammatable=cmsBuildParametricGamma(256,4,params); ^~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:160:4: note: suggested alternative: ‘mutable’ gammatable=cmsBuildParametricGamma(256,4,params); ^~~~~~~~~~ mutable ../profilemanager/lcmswrapper_lcms1.h:160:15: error: ‘cmsBuildParametricGamma’ was not declared in this scope gammatable=cmsBuildParametricGamma(256,4,params); ^~~~~~~~~~~~~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:160:15: note: suggested alternative: ‘cmsBuildParametricToneCurve’ gammatable=cmsBuildParametricGamma(256,4,params); ^~~~~~~~~~~~~~~~~~~~~~~ cmsBuildParametricToneCurve ../profilemanager/lcmswrapper_lcms1.h:168:4: error: ‘gammatable’ was not declared in this scope gammatable=cmsBuildGamma(256,gamma); ^~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:168:4: note: suggested alternative: ‘mutable’ gammatable=cmsBuildGamma(256,gamma); ^~~~~~~~~~ mutable ../profilemanager/lcmswrapper_lcms1.h:168:38: error: invalid conversion from ‘int’ to ‘cmsContext {aka _cmsContext_struct*}’ [-fpermissive] gammatable=cmsBuildGamma(256,gamma); ^ In file included from ../profilemanager/lcmswrapper_lcms1.h:22:0, from ../profilemanager/lcmswrapper.h:5, from imagesource.cpp:3: /usr/include/lcms2.h:1166:36: note: initializing argument 1 of ‘cmsToneCurve* cmsBuildGamma(cmsContext, cmsFloat64Number)’ CMSAPI cmsToneCurve* CMSEXPORT cmsBuildGamma(cmsContext ContextID, cmsFloat64Number Gamma); ^~~~~~~~~~~~~ In file included from ../profilemanager/lcmswrapper.h:5:0, from imagesource.cpp:3: ../profilemanager/lcmswrapper_lcms1.h: In destructor ‘CMSGamma::~CMSGamma()’: ../profilemanager/lcmswrapper_lcms1.h:172:16: error: ‘gammatable’ was not declared in this scope cmsFreeGamma(gammatable); ^~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:172:16: note: suggested alternative: ‘mutable’ cmsFreeGamma(gammatable); ^~~~~~~~~~ mutable ../profilemanager/lcmswrapper_lcms1.h:172:3: error: ‘cmsFreeGamma’ was not declared in this scope cmsFreeGamma(gammatable); ^~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:172:3: note: suggested alternative: ‘cmsBuildGamma’ cmsFreeGamma(gammatable); ^~~~~~~~~~~~ cmsBuildGamma ../profilemanager/lcmswrapper_lcms1.h: At global scope: ../profilemanager/lcmswrapper_lcms1.h:203:2: error: ‘LPGAMMATABLE’ does not name a type LPGAMMATABLE gammatables[3]; ^~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h: In constructor ‘CMSRGBGamma::CMSRGBGamma(float, float, float)’: ../profilemanager/lcmswrapper_lcms1.h:190:3: error: ‘gammatables’ was not declared in this scope gammatables[0]=redgamma.GetGammaTable(); ^~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:190:3: note: suggested alternative: ‘mutable’ gammatables[0]=redgamma.GetGammaTable(); ^~~~~~~~~~~ mutable ../profilemanager/lcmswrapper_lcms1.h:190:27: error: ‘class CMSGamma’ has no member named ‘GetGammaTable’ gammatables[0]=redgamma.GetGammaTable(); ^~~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:191:29: error: ‘class CMSGamma’ has no member named ‘GetGammaTable’ gammatables[1]=greengamma.GetGammaTable(); ^~~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:192:28: error: ‘class CMSGamma’ has no member named ‘GetGammaTable’ gammatables[2]=bluegamma.GetGammaTable(); ^~~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h: In constructor ‘CMSRGBGamma::CMSRGBGamma(float)’: ../profilemanager/lcmswrapper_lcms1.h:197:3: error: ‘gammatables’ was not declared in this scope gammatables[0]=redgamma.GetGammaTable(); ^~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:197:3: note: suggested alternative: ‘mutable’ gammatables[0]=redgamma.GetGammaTable(); ^~~~~~~~~~~ mutable ../profilemanager/lcmswrapper_lcms1.h:197:27: error: ‘class CMSGamma’ has no member named ‘GetGammaTable’ gammatables[0]=redgamma.GetGammaTable(); ^~~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:198:29: error: ‘class CMSGamma’ has no member named ‘GetGammaTable’ gammatables[1]=greengamma.GetGammaTable(); ^~~~~~~~~~~~~ ../profilemanager/lcmswrapper_lcms1.h:199:28: error: ‘class CMSGamma’ has no member named ‘GetGammaTable’ gammatables[2]=bluegamma.GetGammaTable(); ^~~~~~~~~~~~~ In file included from imagesource.h:19:0, from imagesource.cpp:4: ../support/refcountptr.h: At global scope: ../support/refcountptr.h:142:49: warning: ‘template<class> class std::auto_ptr’ is deprecated [-Wdeprecated-declarations] template <class Y> RefCountPtr& operator=(std::auto_ptr<Y>& r) ^~~~~~~~ In file included from /usr/include/c++/7/memory:80:0, from ../support/refcountptr.h:14, from imagesource.h:19, from imagesource.cpp:4: /usr/include/c++/7/bits/unique_ptr.h:51:28: note: declared here template<typename> class auto_ptr; ^~~~~~~~ Makefile:597: recipe for target 'imagesource.lo' failed

[arnaldorusso]

I confirm the same errors.