Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HACKNET: spendHashes handles invalid targets inconsistently #1785

Open
gmcew opened this issue Nov 19, 2024 · 0 comments
Open

HACKNET: spendHashes handles invalid targets inconsistently #1785

gmcew opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gmcew
Copy link
Collaborator

gmcew commented Nov 19, 2024

from #1782, ns.hacknet.spendHashes handles different invalid targets inconsistently, and additionally differently from the UI validity check logic.

To avoid making a breaking change with ns.hacknet.spendHashes (https://github.com/bitburner-official/bitburner-src/blob/d824cd4fa6692ca1e04173b892278b79587a88fb/src/Hacknet/HacknetHelpers.tsx), I don't touch it in this PR, but I want to hear your opinions about it:

When it sees a hashserver, it returns false without printing a warning.
Home and private servers are valid targets. It's inconsistent with how we determine the target in the UI. It's not exploitable, so it's not urgent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmcew