Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Return Value of get_host_subject_id in source_repo.py #552

Open
cassidysymons opened this issue Dec 5, 2023 · 0 comments
Open

Adjust Return Value of get_host_subject_id in source_repo.py #552

cassidysymons opened this issue Dec 5, 2023 · 0 comments

Comments

@cassidysymons
Copy link
Collaborator

Currently, get_host_subject_id returns a tuple, which is causing host_subject_id to be represented in Qiita as ['VALUE'] rather than VALUE. The function's value should be changed to a string and a unit test should be created to assert that it has been fixed.

We're intentionally deferring on this change until January 2024, as there are downstream consequences in Qiita and Redbiom that we'll need to deal with simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant