You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just observed an issue where blank rows in a spreadsheet used to place a bulk order with Daklapack were treated as data and our system attempted to place empty orders through Daklapack's API. When I open the XLS file, I see two rows - the header, and a single address. However, when I convert the XLS file to CSV, it renders as follows (with most of the actual values redacted):
When our system processed the file for ordering, it returned one success message for the row with actual values, then 11 validation errors from the Daklapack API for the empty rows.
While this is largely an issue with Excel functioning counterintuitively, it would be good to enforce very basic validation before attempting to place a bulk order with Daklapack, such as making sure all required fields are present. If a row is entirely empty, silently discarding the row would be fine. Otherwise, warning the user without attempting to contact Daklapack's API for that row would be appropriate.
The text was updated successfully, but these errors were encountered:
I just observed an issue where blank rows in a spreadsheet used to place a bulk order with Daklapack were treated as data and our system attempted to place empty orders through Daklapack's API. When I open the XLS file, I see two rows - the header, and a single address. However, when I convert the XLS file to CSV, it renders as follows (with most of the actual values redacted):
When our system processed the file for ordering, it returned one success message for the row with actual values, then 11 validation errors from the Daklapack API for the empty rows.
While this is largely an issue with Excel functioning counterintuitively, it would be good to enforce very basic validation before attempting to place a bulk order with Daklapack, such as making sure all required fields are present. If a row is entirely empty, silently discarding the row would be fine. Otherwise, warning the user without attempting to contact Daklapack's API for that row would be appropriate.
The text was updated successfully, but these errors were encountered: