How to deal with "Error uploading files"?

[PencilVoid]

I'd like to preface this by stating I am not very smart and this is my first time using Github Actions. When I push a commit, everything seems to go fine except for "Deploy to neocities". In the log, there is an error stating "Error uploading files". The log contains two more lines after this:

##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Deploy to neocities

and then ends. There is also a warning about Node.js 12 actions being deprecated, but I'm not sure whether that is related.
I have no idea how to fix this, and would appreciate assistance from anyone who's encountered this and managed to get around it. For reference, my .github/workflows/neocities.yml file looks like this:

name: Deploy to neocities

# only run on changes to main
on:
  push:
    branches:
      - main

jobs:
  deploy:
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v3
    # When the dist_dir is ready, deploy it to neocities
    - name: Deploy to neocities
      uses: bcomnes/deploy-to-neocities@v1
      with:
        api_token: ${{ secrets.NEOCITIES_API_TOKEN }}
        cleanup: false
        dist_dir: site

The contents of the website are contained in a folder named site.

[bcomnes]

This usually happens when people try to deploy files that neocities doesn't like. Can you link me to the repo or GitHub action log output?

[PencilVoid]

Just made it public, so you should be able to see it here: https://github.com/PencilVoid/neocities-pencilvoid/actions/runs/3399886932/jobs/5653978239
Every commit so far is just me messing around with random things trying to get it to work.

[bcomnes]

The stack trace didn't print the error cause for some reason. I just pushed new version of deploy-to-neocities that will print more of the error. If you try again and see an error, let me know and I can help decipher the cause hopefully this time.

[PencilVoid]

This is what it prints now:

ErrorWithCause: Error uploading files
Files to upload: 
    at NeocitiesAPIClient.deploy (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:356:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
caused by: ErrorWithCause: Neocities API error
    at NeocitiesAPIClient.batchPost (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:211:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
caused by: JSONHTTPError: Bad Request
    at handleResponse (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/fetch-errors/index.js:8:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at NeocitiesAPIClient.batchPost (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:208:1)
    at async Promise.all (index 0)
    at NeocitiesAPIClient.deploy (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:353:1)
    at doDeploy (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/index.js:32:1)

I'm not sure what this means.

[bcomnes]

Ok, thats a little bit better of an error. Let me see if I can expose the body of the request error. That should hopefully have info on what file you are uploading that neocities is rejecting.

[bcomnes]

Sorry I haven't forgotten about this. I plan on looking into this issue more. One or more of the files you are trying to upload is being rejected by the API most likely, so if you want to experiment with something in the meantime, it would be figuring out which file is triggering that. If you do find out, let me know.

[PencilVoid]

I'll try that when I find the time for it (in a few hours). I don't think it's to do with file types since all of the content I'm trying to upload was downloaded from Neocities and edited.

[PencilVoid]

Found something interesting:

2s
Run bcomnes/deploy-to-neocities@v1
Starting inspecting stage...
Finished inspecting stage.
Starting diffing stage...
Finished diffing stage.
Starting applying stage...
Stage applying: 0.00% (0 B / 263 B)
Stage applying: 100.00% (263 B / 263 B)
Finished error stage.
ErrorWithCause: Error uploading files
Files to upload: 
    at NeocitiesAPIClient.deploy (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:356:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
caused by: ErrorWithCause: Neocities API error
    at NeocitiesAPIClient.batchPost (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:211:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
caused by: JSONHTTPError: Bad Request
    at handleResponse (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/fetch-errors/index.js:8:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at NeocitiesAPIClient.batchPost (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:208:1)
    at async Promise.all (index 0)
    at NeocitiesAPIClient.deploy (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/node_modules/async-neocities/index.js:353:1)
    at doDeploy (/home/runner/work/_actions/bcomnes/deploy-to-neocities/v1/webpack:/deploy-to-neocities/index.js:32:1)
[
  {
    name: 'art/desktop.ini',
    path: '/home/runner/work/neocities-pencilvoid/neocities-pencilvoid/site/art/desktop.ini'
  }
]
Error: Error uploading files

There is no file named desktop.ini in the folder named art.

[bcomnes]

There seems to be! https://github.com/PencilVoid/neocities-pencilvoid/blob/main/site/art/desktop.ini

Try deleting that.

[bcomnes]

You probably need to add hidden files added by your operating system to your .gitignore file for the project or your global git settings.

[PencilVoid]

Adding **/desktop.ini to .gitignore and deleting the existing one worked. Thank you very much for your help! It seems to be working now; changes I make locally and push are reflected on Neocities.