Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode option independent of OS system #80

Open
OneCreek opened this issue Oct 4, 2024 · 4 comments
Open

Dark mode option independent of OS system #80

OneCreek opened this issue Oct 4, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@OneCreek
Copy link

OneCreek commented Oct 4, 2024

Would it be possible to have a setting - additionally to overtaking the system theme mode - to also set a manual overrule for light or dark mode?

@MrApplejuice MrApplejuice added this to the Next release milestone Oct 4, 2024
@MrApplejuice
Copy link
Collaborator

Definitely possible, quite easy actually compared to the other stuff... I will plan it in for the next feature release.

@OneCreek
Copy link
Author

OneCreek commented Oct 4, 2024

How can it be the graphics look so different on a

Google Pixel
Screenshot_20241004-221434.png

Compared to a

Xiaomi
Screenshot_2024-10-04-22-09-37-710_eu.pkgsoftware.babybuddywidgets~2.jpg

@MrApplejuice MrApplejuice added the enhancement New feature or request label Oct 7, 2024
@MrApplejuice
Copy link
Collaborator

Hi @OneCreek!

I do not have a Xiaomi phone and cannot reproduce the error on my side. So I "talked it out" with ChatGPT instead... results inconclusive, though it maybe had some relevant points:

  • Something that we could test together: There seems to be an option android:forceDarkAllowed="false" which might be relevant. It might prevent the Xiaomi Android version from overloading my app's dark mode theme. I could upload a "beta version" to google-play so that you can test it (you would need to opt in to that, and see note below)
  • ChatGPT pointed me to "Xiaomi devices have options for color profiles in display settings". Seems to check out according to this video: https://youtu.be/3Rgqo5aTB8c?t=44 Are any of these options active that are "not standard" on the Xiaomi phone, maybe? Those definitely might cause discoloring.

For the first option, we still need to wait for a resolution to my appeal to Google regarding the suspected "sexual content" policy violation on the Google play store. So this might take another week or so... cannot quite tell at the moment.

@OneCreek
Copy link
Author

Hi @OneCreek!

I do not have a Xiaomi phone and cannot reproduce the error on my side. So I "talked it out" with ChatGPT instead... results inconclusive, though it maybe had some relevant points:

  • Something that we could test together: There seems to be an option android:forceDarkAllowed="false" which might be relevant. It might prevent the Xiaomi Android version from overloading my app's dark mode theme. I could upload a "beta version" to google-play so that you can test it (you would need to opt in to that, and see note below)
  • ChatGPT pointed me to "Xiaomi devices have options for color profiles in display settings". Seems to check out according to this video: https://youtu.be/3Rgqo5aTB8c?t=44 Are any of these options active that are "not standard" on the Xiaomi phone, maybe? Those definitely might cause discoloring.

For the first option, we still need to wait for a resolution to my appeal to Google regarding the suspected "sexual content" policy violation on the Google play store. So this might take another week or so... cannot quite tell at the moment.

Yes I think it was due to a Xiaomi individual override functionality! Thanks for the research and support.

Waiting for the app specific support:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants