Add missing things in core-js-pure 3 #198
Conversation
liuxingbaoyu
changed the title
purepure
liuxingbaoyu
changed the title
pure
| @@ -355,7 +355,7 @@ export const StaticProperties: ObjectMap2<CoreJSPolyfillDescriptor> = { | |||
| }, | |||
|
|
|||
| ArrayBuffer: { | |||
| isView: define(null, ["es.array-buffer.is-view"]), | |||
| isView: define("array-buffer/is-view", ["es.array-buffer.is-view"]), | |||
There was a problem hiding this comment.
It's missed in the pure version.
There was a problem hiding this comment.
| groupBy: define(null, ["es.map.group-by", ...MapDependencies]), | ||
| keyBy: define(null, ["esnext.map.key-by", ...MapDependencies]), | ||
| of: define(null, ["esnext.map.of", ...MapDependencies]), | ||
| from: define("map/from", ["esnext.map.from", ...MapDependencies]), |
There was a problem hiding this comment.
.from and .of are present in all collections.
|
Yes, it looks like a partial workaround. |
| "es.promise.any", | ||
| "es.aggregate-error", | ||
| ...PromiseDependenciesWithIterators, | ||
| ]), | ||
| race: define(null, PromiseDependenciesWithIterators), | ||
| try: define(null, ["esnext.promise.try", ...PromiseDependencies]), | ||
| try: define("promise/try", ["esnext.promise.try", ...PromiseDependencies]), | ||
| withResolvers: define(null, [ |
There was a problem hiding this comment.
It's also a static method - it was added recently, but with Map.groupBy situation the same.
| _WeakMap.from; | ||
| _ArrayBuffer$isView; | ||
| Uint8Array.from; | ||
| Uint8Array.of; |
There was a problem hiding this comment.
Is this expected? I didn't find the corresponding file.
There was a problem hiding this comment.
All typed array features are not polyfilled in the pure version.
liuxingbaoyu
force-pushed
the
fix-map-groupby
branch
from
f819cb0 to
6dd5400
Compare
...ges/babel-plugin-polyfill-corejs3/test/fixtures/usage-pure/built-in-static-methods/output.js
Outdated
Show resolved
Hide resolved
|
Thank you! |
That means that those entries should be defined for all collections, not removed from |
Oops, I just tested that |
Fixes: #166
It seems that issues is not the optimization logic, but that we don't define the data of
corejs-pure.