Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socketPath feature is broken at 1.7.7 #6611

Open
Jssly opened this issue Sep 24, 2024 · 4 comments · May be fixed by #6623
Open

socketPath feature is broken at 1.7.7 #6611

Jssly opened this issue Sep 24, 2024 · 4 comments · May be fixed by #6623

Comments

@Jssly
Copy link

Jssly commented Sep 24, 2024

Describe the bug

throw error TypeError [ERR_INVALID_URL]: Invalid URL if sockPath is used.

To Reproduce

No response

Code snippet

No response

Expected behavior

No response

Axios Version

1.7.7

Adapter Version

No response

Browser

No response

Browser Version

No response

Node.js Version

18.20.2

OS

Win 11

Additional Library Versions

No response

Additional context/Screenshots

TypeError [ERR_INVALID_URL]: Invalid URL
    at new NodeError (node:internal/errors:405:5)
    at new URL (node:internal/url:676:13)
    at dispatchHttpRequest (file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/adapters/http.js:232:20)
    at file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/adapters/http.js:152:5
    at new Promise (<anonymous>)
    at wrapAsync (file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/adapters/http.js:132:10)
    at http (file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/adapters/http.js:170:10)
    at Axios.dispatchRequest (file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/core/dispatchRequest.js:51:10)
    at Axios._request (file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/core/Axios.js:173:33)
    at Axios.request (file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/core/Axios.js:40:25)
    at Axios.request (file:///F:/git/node/libraries/nodelib_epg/node_modules/axios/lib/core/Axios.js:45:41)
@PritamP20
Copy link

any additional informations?

@kartik1809 kartik1809 linked a pull request Oct 1, 2024 that will close this issue
Open
@Anurag0218
Copy link

is this issue open? is anyone working on it? If not, can I take it up?

@PritamP20
Copy link

working on it

@Jssly
Copy link
Author

Jssly commented Oct 13, 2024

@PritamP20 more informtion, in this case, the socketPath is an Unix domain socket , that means it's a file path.

example:
axios({ url: '/testing', socketPath:'/tmp/nginx.sock' })

it works fine in 1.7.3. but fails in 1.7.4+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6611 Fix URL handling to prevent invalid URL errors kartik1809/axios
3 participants
@Jssly @PritamP20 @Anurag0218