Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--cert-selector with string argument incorrectly fails when a Value includes a space #82

Open
chalford opened this issue Oct 10, 2024 · 1 comment

Comments

@chalford
Copy link

Apologies if I have missed some documentation that describes how to do this.

getStringMap() in credentials.go does strings.Split(s, " ") on the --cert-selector argument. If the Value is a DN that includes components with spaces, these get split incorrectly.

Perhaps either of these would be a way to approach the problem:

  1. The --cert-selector argument provides some way to substitute spaces with another character, or,
  2. The --cert-selector argument uses a different separator character (than space) for each key-value pair

A workaround exists by using the file:// argument with a JSON file, where a space in the Value field works as expected.

@13ajay
Copy link
Contributor

13ajay commented Oct 15, 2024

You're right, the current workaround is to use a file as the selector as you said. I had started to address this issue in #66, but that requires some updates at this point. I'll discuss further with my colleagues and hopefully address it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants