Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to have multiple --local-forwarding arguments to ec2-instance-connect ssh command #9101

Open
2 tasks
lludsubaru opened this issue Nov 22, 2024 · 3 comments
Labels
customization Issues related to CLI customizations (located in /awscli/customizations) ec2-instance-connect feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@lludsubaru
Copy link

Describe the feature

The aws ec2-instance-connect ssh command already takes in one parameter for a local forwarding string; the ssh program supports multiple local forwarding options so allowing multiple would help when there is more than one forwarding rule desired

Use Case

Often when connecting into a VPC to run something locally, you might have a database instance and a elastic cache instance or something similar. Being able to forward ports for both of them on a single command is simpler than running multiple ssh commands.

Proposed Solution

Wish I was more of a python developer, but it seems like there should be a way to tag an argument as one that can be provided multiple times and then just loop through those arguments when creating the ssh command and adding the "-L" options to it.

Other Information

I tried putting multiple --local-forwarding parameters but it only seems to use the last one

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CLI version used

aws-cli/2.13.22 Python/3.11.5 Windows/10 exe/AMD64 prompt/off

Environment details (OS name and version, etc.)

Windows 11

@lludsubaru lludsubaru added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2024
@tim-finnigan tim-finnigan self-assigned this Nov 26, 2024
@tim-finnigan tim-finnigan added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Nov 26, 2024
@tim-finnigan
Copy link
Contributor

Thanks for the feature request. The ec2-instance-connect customization is maintained by another team internally so I'll reach out to them for feedback on this. In the meantime others can 👍 your issue to +1 it, and if there are any additional details you can share regarding your use case please do.

@tim-finnigan tim-finnigan added customization Issues related to CLI customizations (located in /awscli/customizations) ec2-instance-connect p2 This is a standard priority issue and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2024
@tim-finnigan tim-finnigan removed their assignment Nov 26, 2024
@tim-finnigan
Copy link
Contributor

We heard back from the team maintaining this customization, and they noted that this feature request may be a duplicate (or closely overlap with) another recent issue: #8952. We may want to consolidate these for tracking going forward, or otherwise elaborate on specific differences. Regarding #8952 — the team acknowledged that it would be a beneficial enhancement of the plugin and added the feature request to their backlog for further tracking.

@tim-finnigan tim-finnigan added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 2, 2024
@lludsubaru
Copy link
Author

Thanks Tim ( and team ). I think that makes sense both being about parameters passed; but it sounds like two different sets of parameters. one: to have multiple of a specific parameter that is already there, and two: the ability to pass additional custom commands to the ssh call. The 2nd one would probably satisfy my use case but since there is already a specific parameter for creating a tunnel it seems like it would be cleaner to implement it with a repeated parameter. But obviously, whatever works best for your team is great.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization Issues related to CLI customizations (located in /awscli/customizations) ec2-instance-connect feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants