Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws ec2 import-snapshot does not set the snapshot description #9047

Closed
rgl opened this issue May 24, 2024 · 9 comments
Closed

aws ec2 import-snapshot does not set the snapshot description #9047

rgl opened this issue May 24, 2024 · 9 comments
Assignees
Labels
bug This issue is a bug. ec2 service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@rgl
Copy link

rgl commented May 24, 2024

Describe the bug

when using the

aws_region='eu-west-1'
vmimport_role='arn to a role like the one from https://docs.aws.amazon.com/vm-import/latest/userguide/required-permissions.html#vmimport-role'
talos_version='1.7.2'
s3_bucket='images'
s3_key="talos-$talos_version-aws-amd64.vmdk"
aws ec2 import-snapshot \
    --region "$aws_region" \
    --role-name "$vmimport_role" \
    --description "Talos Linux $talos_version" \
    --disk-container "Description=Talos Linux $talos_version,Format=VMDK,UserBucket={S3Bucket=$s3_bucket,S3Key=$s3_key}"

Notice the --disk-container "Description=Talos Linux $talos_version, argument.

I would expect that to set the snapshot description. But it does not.

Expected Behavior

I would expect --disk-container "Description=Talos Linux $talos_version, to set the snapshot description.

Current Behavior

It sets the snapshot description to Created by AWS-VMImport service for ... instead of the expected value.

Here's a screenshot of the aws management console while listing the created snapshot:

image

Reproduction Steps

execute the command as described earlier.

Possible Solution

No response

Additional Information/Context

No response

CLI version used

2.15.53

Environment details (OS name and version, etc.)

ubuntu 22.04

@rgl rgl added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 24, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK self-assigned this Jun 4, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK added investigating This issue is being investigated and/or work is in progress to resolve the issue. ec2 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 4, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

Hi @rgl, thanks for reaching out. The EC2 service team is aware of this behavior; only the task description is making it to the resulting snapshot, as opposed to both the task description and snapshot description. They have a backlog item to address this issue, and I've reached out to them for an update. As this is a service team issue (not CLI specific), I'm going to move this issue to our cross-SDK repository. Thanks again for opening this.

Ticket # for internal use : D1088854

@RyanFitzSimmonsAK RyanFitzSimmonsAK removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Jun 11, 2024
@RyanFitzSimmonsAK RyanFitzSimmonsAK transferred this issue from aws/aws-cli Jun 11, 2024
@tim-finnigan tim-finnigan added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Jul 3, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

RyanFitzSimmonsAK commented Aug 28, 2024

Thanks for your patience. The EC2 acknowledged the issue and clarified the current behavior.

--description sets the description of the job.
--disk-container Description sets the description of the disk image, but at this time, this option doesn't work. They're currently investigating this behavior.

Neither option sets or is intended to set the description of the snapshot.

If you'd like, I'd be happy to forward this as a feature request to be able to set snapshot descriptions with ImportSnapshot. Otherwise, please let me know if you have any follow-up questions.

@RyanFitzSimmonsAK RyanFitzSimmonsAK added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 28, 2024
@rgl
Copy link
Author

rgl commented Aug 29, 2024

@RyanFitzSimmonsAK, thanks for the update and clarifications!

Please do forward the request, as having a way to set the snapshot description is the most important part, as that is what we can actually see at the Amazon Console (as depicted in the screenshot from above).

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 29, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

Sure thing!

Ticket # for internal use : P151539240

@RyanFitzSimmonsAK
Copy link
Contributor

Transferring this issue to the aws-cli repo for tracking going forward.

@RyanFitzSimmonsAK RyanFitzSimmonsAK transferred this issue from aws/aws-sdk Oct 30, 2024
@RyanFitzSimmonsAK
Copy link
Contributor

I've forwarded this feature request to the EC2 team. Thanks again for reaching out.

Copy link

github-actions bot commented Nov 5, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@rgl
Copy link
Author

rgl commented Nov 7, 2024

@RyanFitzSimmonsAK, please, link the aws cli version that fixed this issue.

@RyanFitzSimmonsAK
Copy link
Contributor

@RyanFitzSimmonsAK, please, link the aws cli version that fixed this issue.

This behavior isn't resolved yet; the EC2 team has been made aware of this request, but there's no specific timeline for implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. ec2 service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants